[libsystemd] Fix build on 26.04 ubuntu systems#51570
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom May 6, 2026
Merged
[libsystemd] Fix build on 26.04 ubuntu systems#51570BillyONeal merged 2 commits intomicrosoft:masterfrom
BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
BillyONeal
approved these changes
May 6, 2026
Member
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
I'm going to merge this on the grounds that we normally disable warnings-as-errors but the specific errors should be reported to upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some Werror arguments in the building of libsystemd that caused the build to fail when using a docker container of ubuntu 26.04. I tested using the following:
docker run -it ubuntu:26.04 apt install -y ca-certificates curl gnupg lsb-release openjdk-17-jre-headless git sudo vim openssh-client build-essential ninja-build openjdk-21-jre fontconfig \ zip unzip tar autoconf autoconf-archive automake libtool \ linux-libc-dev pkg-config software-properties-common \ nasm bison flex \ libx11-dev libxext-dev libxrender-dev libxtst-dev libxrandr-dev \ libltdl-dev libxi-dev libxcursor-dev libxinerama-dev \ libgl1-mesa-dev libglu1-mesa-dev libasound2-dev \ libvulkan-dev libwayland-dev libxkbcommon-dev \ libssl-dev libbz2-dev liblzma-dev libudev-dev libdrm-dev \ libglfw3-dev libgtk-3-dev \ libavcodec-dev libavformat-dev libavutil-dev libswscale-dev libswresample-dev \ libxcb1-dev libxcb-render0-dev libxcb-shape0-dev libxcb-xfixes0-dev \ libx11-xcb-dev libxkbcommon-x11-dev libegl1-mesa-dev \ python3 python3-venv openjdk-21-jdk openjdk-25-jdk openjdk-17-jdk \ '^libxcb.*-dev' libx11-xcb-dev libglu1-mesa-dev libxrender-dev libxi-dev libxkbcommon-dev \ libxkbcommon-x11-dev libegl1-mesa-dev clang-tidy clang-tools clang-format codespell cppcheck curl -fsSL https://apt.kitware.com/keys/kitware-archive-latest.asc \ -o /usr/share/keyrings/kitware-archive-keyring.asc && \ echo "deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.asc] https://apt.kitware.com/ubuntu/ $(lsb_release -cs) main" \ > /etc/apt/sources.list.d/kitware.list && \ apt-get update && apt-get install -y cmake git clone https://github.com/Microsoft/vcpkg && cd vcpkg && ./bootstrap-vcpkg.sh && ./vcpkg install libsystemd./vcpkg x-add-version --alland committing the result.